Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[perf] Try revert of #102472 #109780

Closed
wants to merge 1 commit into from
Closed

[perf] Try revert of #102472 #109780

wants to merge 1 commit into from

Conversation

lqd
Copy link
Member

@lqd lqd commented Mar 30, 2023

Since we don't have a perf run or unrolled builds for PR #102472, let's try perf on a revert and see if it's the regression source in the #109692 rollup as suspected here #109692 (comment).

r? @ghost

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Mar 30, 2023
@lqd
Copy link
Member Author

lqd commented Mar 30, 2023

@bors try @rust-timer queue

@rust-timer

This comment has been minimized.

Sign in to view
@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Mar 30, 2023
@bors
Copy link
Contributor

bors commented Mar 30, 2023

⌛ Trying commit 0026d96 with merge 8d0b21023d7793848a84ec3f620c8969711e64b1...

@lqd lqd mentioned this pull request Mar 30, 2023
Merged
@bors
Copy link
Contributor

bors commented Mar 30, 2023

☀️ Try build successful - checks-actions
Build commit: 8d0b21023d7793848a84ec3f620c8969711e64b1 (8d0b21023d7793848a84ec3f620c8969711e64b1)

1 similar comment
@bors
Copy link
Contributor

bors commented Mar 30, 2023

☀️ Try build successful - checks-actions
Build commit: 8d0b21023d7793848a84ec3f620c8969711e64b1 (8d0b21023d7793848a84ec3f620c8969711e64b1)

@rust-timer

This comment has been minimized.

Sign in to view
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (8d0b21023d7793848a84ec3f620c8969711e64b1): comparison URL.

Overall result: ✅ improvements - no action needed

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

@bors rollup=never
@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 0.3% [0.3%, 0.3%] 1
Improvements ✅
(primary)		 -2.0% [-8.7%, -0.2%] 10
Improvements ✅
(secondary)		 -3.9% [-10.1%, -0.6%] 8
All ❌✅ (primary) -2.0% [-8.7%, -0.2%] 10

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 2.7% [2.4%, 3.0%] 2
Improvements ✅
(primary)		 -2.0% [-2.0%, -2.0%] 1
Improvements ✅
(secondary)		 -2.4% [-2.4%, -2.4%] 1
All ❌✅ (primary) -2.0% [-2.0%, -2.0%] 1

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 -5.0% [-7.5%, -2.5%] 2
Improvements ✅
(secondary)		 -4.3% [-8.5%, -2.2%] 6
All ❌✅ (primary) -5.0% [-7.5%, -2.5%] 2

@rustbot rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Mar 31, 2023
@lqd lqd mentioned this pull request Mar 31, 2023
Merged
@Noratrieb Noratrieb added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 5, 2023
@lqd lqd closed this Sep 19, 2023
@lqd lqd deleted the perf-revert-102472 branch September 19, 2023 22:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@lqd @rust-timer @bors @rustbot @Noratrieb